MPC: Add star catalog column #2957
Conversation
|
Hello @tristandijkstra! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-04-06 03:07:39 UTC |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2957 +/- ##
=======================================
Coverage 66.81% 66.81%
=======================================
Files 237 237
Lines 18319 18319
=======================================
Hits 12239 12239
Misses 6080 6080 ☔ View full report in Codecov by Sentry. |
|
Hi @bsipocz, I have updated the PR and tried again but the build still fails. From the log, it appears that the read-the-docs build is failing due to 4 warnings from the ALMA and IRSA services:
Please let me know if there's anything else I can do. |
There was a problem hiding this comment.
All looks good, thank you @tristandijkstra!
I'll do a rebase before merging to get rid of the merge commit, and to get a fully green CI.
Hello,
The MPC 80-column format used by astroquery's
MPC.get_observations()contains a column (col 72) that gives the star catalog used for the observation which is currently not implemented/exposed. This is a simple PR to add that column toMPC.get_observations().Here is some info on that column: https://www.minorplanetcenter.net/iau/info/CatalogueCodes.html